- changed status to open
- removed comment
Case sensitivity GSL_DIR=BUILD
The thorn GSL would not compile if "GSL_DIR=build" in the option list. In order to work, it requires "GSL_DIR=BUILD", i.e. it is really case sensitive although I think, this is not required and should be case insensitive.
Possibly, HDF5_DIR=build may also not work for the same reason (have not checked; should be checked as well).
Keyword: GSL_DIR
Keyword: BUILD
Comments (7)
-
-
- removed comment
build3.patch works; ignore the previous two.
-
- removed comment
(The patch addresses the problem for many thorns in ExternalLibraries other than HDF5, and additionally tidies up some formatting.)
This looks good - please apply.
-
- removed comment
- changed watchers to reisswig
Looks good (but please don't mix up changes in patches which are not related to the issue. The changes are all fine, but make reviewing more complicated). Please apply.
-
- removed comment
Was this patch applied?
-
- changed status to resolved
- removed comment
Yes.
-
- edited description
- changed status to closed
- Log in to comment