Check for periodicity of initial data with Periodic thorn

Create issue
Issue #449 new
Ian Hinder created an issue

When applying periodic boundary conditions with the Periodic thorn, the thorn could check that the initial data it was given was actually periodic. This might help to track down errors in setting up parameter files.

Keyword: Periodic

Comments (2)

  1. Roland Haas
    • removed comment

    if we add this functionality to Periodic. Should it also be added to the Reflection/Rotating symmetry thorns? There might actually be initial data thorns out there that actually rely on the symmetry thorn to enforce symmetries and do not set anything in eg. what look like ghost zones (which will be filled in by symmetry/SYNC). An example would be an ID thorn that uses numerical derivatives eg. to get Kij from the metric, its time derivative and the spatial derivative of beta (ie. CalcK). Are ID thorns required to fill in everything or just the interior?

  2. Erik Schnetter
    • removed comment

    All thorns are supposed to fill in all grid points. If necessary, the thorns have to synchronise and apply a boundary condition.

    A generic mechanism for testing this would be to have an independent thorn that takes a grid function where supposedly all grid points are valid, makes a copy, applies a symmetry boundary condition to the original, and then compares to the copy. Any difference is an error. This would also test synchronisation and boundary conditions.

  3. Log in to comment