Declare all private variables as private

Create issue
Issue #452 closed
Erik Schnetter created an issue

In Fortran OpenMP, loop variables of parallel loops are implicitly private and do not need to be declared as private. I find this somewhat confusing, and I suggest to nevertheless declare them to be private. In particular, when tracking down OpenMP problems I am never sure whether it is a compiler problem, and I want to avoid as much ambiguity as possible. The attached patch does this.


Comments (4)

  1. Frank Löffler
    • removed comment

    I agree, this doesn't harm and makes things clearer, especially when involving the nested 3D loops. Please apply.

  2. Log in to comment