Improve bboxset efficiency (e.g. for regridding)

Create issue
Issue #458 closed
Erik Schnetter created an issue

The attached patch modifies the algorithm used to insert a new bbox into an existing bboxset. It reduces the computational complexity of this operation from O(n^2) to O(n), where n is the number of elements in the bboxset. This has the potential to speed up regridding significantly.


Comments (5)

  1. Ian Hinder
    • removed comment

    I've read the patch, but it is too intricate for me to say much about. My only comment is a meta-comment, if you like, that the patch would have been less daunting if the pure-formatting changes had been separated out so I could ignore them.

    Assuming that this has been tested, that Erik is reasonably confident that it is correct, and that any regridding-related tests (do we have any?) pass, I would say to apply this. The only further review that I could really do would be to run a test BBH simulation with this. Do you think this is necessary, or do you just want to apply it?

    Another issue is that we currently have a number of failing tests, which means that seeing additional failures that might come about as a result of this patch might be hard.

  2. Erik Schnetter reporter
    • removed comment

    Since we are shortly before a freeze I will not commit this change at this time.

  3. Log in to comment