McLachlan doesn't check metric_type

Issue #498 new
Erik Schnetter created an issue

McLachlan doesn't check the metric type, which needs to be "physical". A static conformal factor is not supported.


Comments (4)

  1. Erik Schnetter reporter
    • removed comment

    Actually, McLachlan should check the grid scalar conformal_state, not the parameter metric_type.

  2. Frank Löffler
    • removed comment

    In general: who is using a static conformal factor these days? If nobody really, I suggest to mark this depreciated for the next release and remove it for the one following that.

  3. Erik Schnetter reporter
    • removed comment

    It is used in current example parameter files, and mostly unsuspecting people will trip over it. We could mark it as deprecated, but would then need to update these examples (and possibly test cases).

  4. Ian Hinder
    • removed comment

    I certainly wouldn't put any effort into making McLachlan know about this. Instead spend the time on updating the test cases.

  5. Log in to comment