Change case in internal auto-generated file

Create issue
Issue #540 closed
Erik Schnetter created an issue

Cactus auto-generates header files from CCL files into the bindings/include directory. One of these files is called ${thorn}_arguments.h, which stands out because "a" is lower case. Other auto-generated files are called e.g. ${thorn}_Schedule.h with an upper case "S". I suggest to change "arguments" to upper case "Arguments".


Comments (6)

  1. Ian Hinder
    • removed comment

    What happens if a user updates the flesh and tries to build an existing checkout? Will the build fail because it is looking for a file which does not exist? (This might work on Mac OS where the filesystem is case-insensitive.) I think there is a way to force all configurations to be rebuilt - should we use this?

  2. Erik Schnetter reporter
    • removed comment

    The new file names are only used after code is re-generated. After updating, the flesh continues to use the old files. (This can also be seen from the fact that only perl code is changed, no C files.)

  3. Ian Hinder
    • removed comment

    So the files are all re-generated when the CST runs anyway, so they are either all lowercase or all uppercase.

    In that case, please apply!

  4. Log in to comment