Bad check in AEILocalInterp

Create issue
Issue #570 closed
Steven R. Brandt created an issue

In AEIThorns/AEILocalInterp/src/InterpLocalUniform.c 1370 if (value_not_set) 1371 then { 1372 / default operand will use each input exactly once, / 1373 / but this only makes since if N_input_arrays == N_output_arrays / 1374 if (N_input_arrays != N_input_arrays) 1375 then { 1376 free(input_array_offsets); 1377 free(operand_indices); 1378 CCTK_VWarn(ERROR_MSG_SEVERITY_LEVEL,

The test is always going to fail and data is not going to be freed up. Based on the comment, I think that the test should compare N_input_arrays to N_output_arrays.

Keyword:

Comments (3)

  1. Log in to comment