unused function ParseEnvCommands in simfactory

Create issue
Issue #595 closed
Frank Löffler created an issue

The function ParseEnvCommands is not used in simfactory, and as far as I can tell it is not doing what I think it should do. It should either be fully implemented (but that may already be provided elsewhere), or be removed.


Comments (3)

  1. Roland Haas
    • changed status to resolved
    • edited description

    Removed in git hash fde3271 "simsubs: remove unused and incomplete ParseEnvCommands function" of simfactory2.

    The current implementation had at least 2 bugs:

    1. it was substituting the empty string for everything
    2. the pattern to find @ENV(...)@ was way to greedy and assume whitespace after which would have prevented such uses as @END(SCRATCH)@/simulations which would be useful eg on TACC machines

    Finally Cactus itself can use ENV in parameter files.

  2. Log in to comment