ML_ADMConstraints is incorrect

Create issue
Issue #671 closed
Ian Hinder created an issue

ML_ADMConstraints does not compute the constraints correctly. There are errors in the computation of the Ricci tensor. The attached patch corrects these errors. OK to apply?

Keyword: ML_ADMConstraints

Comments (6)

  1. Erik Schnetter
    • removed comment

    Please apply.

    In the BSSN equations, we improved the speed by introducing more local variables for some of the temporaries, instead of have many loops (bound indices) in the equations.

  2. Ian Hinder reporter
    • removed comment

    I have also committed a fix to McLachlan_ADM where the error was repeated (probably it was copied from there originally). Do we need the constraints computed in both places?

  3. Log in to comment