parameter default change in CarpetIOASCII

Create issue
Issue #677 closed
Luca Baiotti created an issue

I suggest to change the default values of the following parameters from yes to no:

BOOLEAN output_ghost_points BOOLEAN out3D_ghosts
BOOLEAN out3D_outer_ghosts

They refer to debug output and at this time I think they may be off by default. Some of them are also deprecated.

See also the mailing list thread "questions on CarpetIOASCII".

Keyword: CaroetIOASCII
Keyword: parameter
Keyword: default

Comments (6)

  1. Erik Schnetter
    • removed comment

    A quick note: If a parameter is deprecated, it should not be used if possible, and consequently its default should not be changed either.

  2. Erik Schnetter
    • removed comment

    Luca, do you want to discuss this on the mailing list? This ticket seems to be ignored, and the changing a default value should be done by consensus.

  3. Erik Schnetter
    • removed comment

    This issue was raised on the mailing list (October 10, 2011, subject "Questions on CarpetIOASCII"), but no discussion followed. Since changing default values can be inconvenient for many people, I suggest to not change the default unless there is a consensus in a discussion.

  4. Roland Haas
    • removed comment

    I am fine with a change of default parameters. I am in the fraction that "don't care about the change" (in the sense that I don't mind whether or not it happens) and I'd rather speak up now than complain about it afterwards. I would suspect that this change requires all tests that use CarpetIOASCII's 1d output to be regenerated since the number of points output changes?

    Otherwise: fine by me to apply even if it means allmost all of my parameter files will change behaviour.

  5. Erik Schnetter
    • changed status to resolved
    • removed comment

    There was no discussion, and my original point stands -- without discussion and consensus I would rather keep the current default values. There are many cases in the Einstein Toolkit where the default values are inconvenient, and are only there for backward compatibility, e.g. most things having to do with coordinates or buffer zones.

  6. Log in to comment