- changed status to open
- changed component to EinsteinToolkit thorn
- removed comment
LSUThorns/Vectors: Simplify API for partial vector stores
Issue #682
closed
Implement vec_store_nta_partial, which offers a simpler interface, similar to the one used in OpenCL.
Keyword:
Comments (4)
-
reporter -
- removed comment
It looks like you have two "else if (v8stp_lo)" in the SSE4A part of the patch. Should the second of these be "else if (v8stp_hi)"? If so,would the tests have picked this up on an SSE4A machine? If so, and the AVX code also pases the test, I think this should be applied. I'd also recommend adding a pseudo-code comment explaining what the AVX version does.
-
reporter - changed status to resolved
- removed comment
Applied.
-
- edited description
- changed status to closed
- Log in to comment