- changed status to open
- removed comment
Cleanup in script CreateConfigurationBindings.pl
Some cleanup: Use my, use better variable names, re-indent.
Keyword:
Comments (6)
-
reporter -
- removed comment
This looks OK - please apply.
-
- removed comment
Was this applied?
-
- removed status
- removed comment
This patch clean-up CreateConfigurationBindings.pl in several different ways: rename scalar variables to improve readability, get rid of temporary variable, apply proper variable scoping, reorder script execution. I looked carefully into this patch and have only two minor comments (that can be addressed after applying this patch):
1) In the original file there was not prepending of #include as it shows now on line 104 of the patched file:
- Prepend #include $inc =~ s/^(.*)/#include $1/gm; $incs .= $inc;
Was this intentional?
2) Fix typo on line 110: # These string --> # These strings
Other than that the patch looks good and improves readability of the script. Please apply!
-
reporter - changed status to resolved
- removed comment
(1) Yes, this was missing (2) Thanks
-
- edited description
- changed status to closed
- Log in to comment