Check extent of interpolation stencils in CarpetInterp2

Create issue
Issue #693 closed
Erik Schnetter created an issue

Do what these comments say in fasterp.cc of CarpetInterp2:

// TODO: assert that there are enough ghost zones

// TODO: store for every face/direction/component/map/reflevel // how wide the boundaries are in every direction. Then check // against this when the stencils are set up.

Keyword:

Comments (6)

  1. Erik Schnetter reporter
    • changed status to open
    • removed comment

    The attached patch adds more error checking to CarpetInterp2. Please test this patch if you run multi-patch simulations.

  2. Roland Haas
    • removed comment

    The logic in lines 963 and 229,289,296 seems inverted. calc_stencil seems to return 0 when everything is fine and -1 upon errors. So the check in 963 should be "if(ierr) { CCTK_Warn... }".

    Otherwise harmless it seems. The routines are not used by anything (public) in ET right now either. Please apply (with the change above if correct).

  3. Ian Hinder
    • removed comment

    Yes, I discovered the same thing and discussed it on the Llama mailing list. It seems to work fine with multipatch (with that logic change) and could be committed.

  4. Log in to comment