Activation Order in Parameter Files

Create issue
Issue #705 resolved
Steven R. Brandt created an issue

At the moment the ActiveThorns list is sensitive to the order in which thorns are activated if the ActiveThorns parameter is updated multiple times. However, it is not sensitive to the order in which thorns are activated if all thorns are specified in a single line. This inconsistency should be removed, and the order should not matter in either case.

Keyword:

Comments (9)

  1. Roland Haas
    • removed comment

    If you have several ActiveThorns lines in your parfile then the order matters. Ie.

    ActiveTHorns = "CarpetLib"
    Carpet::max_refinement_levels = 1
    ActiveTorns = "Carpet"
    

    fails as well as

    ActiveTorns = "Carpet"
    ActiveTHorns = "CarpetLib"
    

    while

    ActiveTorns = "Carpet
                   CarpetLib"
    

    is fine.

  2. Frank Löffler
    • removed comment

    I know that this used to be the case, but Steve told me that piraha actually combines all ActiveThorns requests into one. What I don't know right now is whether that is in trunk already, or still in its own branch. Steve?

  3. Steven R. Brandt reporter
    • removed comment

    As Frank said. Since Piraha, the order should no longer matter. Piraha combines all the ActiveThorn declarations into one before passing it through to Cactus.

  4. Erik Schnetter
    • removed comment

    The Cactus documentation says:

    \item{} The parameter file is read \emph{sequentially} from top to bottom,
            this means that if you set the value of a parameter twice in
            the parameter file, the second value will be used. (This is
            why the \texttt{ActiveThorns} parameter is always first in the file).
    

    Please update this.

    There are also many instances in the users' guide which speak of ActiveThorns as "the first parameter being set". If we allow this to be set multiple times, and if this is commonly used, then this should be mentioned as well.

  5. Roland Haas

    Docs updated in git hash cfe83d60 "Cactus: remove incorrect statement about order or parfile parsing" of cactus . Piraha has been combining all activethorns lines for a while longer already.

  6. Log in to comment