provide names for spherical surfaces

Create issue
Issue #735 closed
Roland Haas created an issue

the attached set of patches provide a simple function

sf_IdFromName(CCTK_INT id, CCTK_STRING name)

(and similar for Fortran) as well as changes for AHFinderDirect, QuasiLocalMeasures and SetMask_SphericalSurface to use it.

The code compiles and passes the testsuites for QLM and AHFinderDirect (testing both with ids by name and by number).

If this code is roughly in concordance with how this ought-to-be-done in Cactus, then please apply (I have commit rights to QLM and AHFinderDirect only but not SphericalSurface and SetMask_SphericalSurface).

Keyword:

Comments (4)

  1. Erik Schnetter
    • changed status to open
    • removed comment

    I like this idea.

    In your example, please use something else but "SphericalSurface0" as surface name -- if this were the road to go, then names don't have any advantage...

    You may want to add parameter checking in SphericalSurface to ensure that all surfaces have distinct names.

    Please apply. Please ask for commit rights to SphericalSurface to do this. Which thorn contains SetMask_SphericalSurface?

  2. Roland Haas reporter
    • removed comment

    I' added a check for uniqueness. I just re-checked which repositories I can write to (by checking in which there is a commit by rhaas). It seems I need only permissions for QuasiLocalMeasures really. I'll ask Frank for permission since it is in LSUThorns. Function SetMask_SphericalSurface is in a thorn EinsteinUtils/SetMask_SphericalSurface by Frank Löffler. As far as I can tell it does more or less what CarpetMask's excluded_surface parameter does.

  3. Log in to comment