- changed status to open
- removed comment
close all HDF5 objects in EOS Omni table reader
hdf5 does not automatically close all object handles of objects in a file if one closes the (last) file handle. This could potentially lead hdf5 to leave metadata in memory (and it is just not tidy to leave open objects around)
Keyword:
Comments (7)
-
reporter -
- removed comment
This patch also declares a function static and removes another function declaration. Is this intentional and related to the problem? It doesn't seem to be.
-
reporter - removed comment
It's intentional. It does not relate to the problem. It should be done though, since pushing a function with the rather common name "file_is_readable" into the global namespace seems dangerous. It removes a function declaration that Cactus now provides on its own. You are certainly correct though. Lines 133 and 134 are the only changes that are actually mentioned in the ticket title.
-
- changed status to open
- removed comment
Was just checking - ok to commit the whole patch, thanks!
-
reporter - removed comment
Hello Frank. Sorry to sound so grumpy. That was not intended. I had written the comment in the two minutes before leaving for a talk. I'll wait until after the release with since it is not critical in any way.
-
reporter - changed status to resolved
- removed comment
Sorry. I had confused
#821and this one. I applied this patch as rev 59 since it is so trivial. Thanks for the review. -
reporter - edited description
- changed status to closed
- Log in to comment