- removed comment
McLachlan "NewRad" radiative boundary condition does not consider conformalMethod
Issue #848
closed
In ML_BSSN_Helper/src/NewRad.c, the newrad function is called with a background value of 0 for the phi variable, independently of the setting of conformalMethod. For conformalMethod = 1, the background value should be 1.
Keyword: McLachlan
Comments (7)
-
reporter -
- changed status to open
- removed comment
-
- changed status to open
- removed comment
Please apply both.
-
- changed milestone to ET_2012_05
- removed comment
-
reporter - changed status to open
- assigned issue to
- removed comment
-
reporter - changed status to resolved
- removed comment
-
- changed status to closed
- edited description
- Log in to comment
There is a patch to fix this at http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=38bfec5d987fe20ee88f202414e40b19df79c979. I have also written a test case for NewRad (http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=9e1e4c5541f36211fbf8a0bf39ac75dfb33783c5). The thorn name will need to be changed to ML_BSSN in the parameter file and test name if this is applied to master.