McLachlan "NewRad" radiative boundary condition does not consider conformalMethod

[Ian Hinder]

In ML_BSSN_Helper/src/NewRad.c, the newrad function is called with a background value of 0 for the phi variable, independently of the setting of conformalMethod. For conformalMethod = 1, the background value should be 1.

Keyword: McLachlan

[Ian Hinder]

There is a patch to fix this at http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=38bfec5d987fe20ee88f202414e40b19df79c979. I have also written a test case for NewRad (http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=9e1e4c5541f36211fbf8a0bf39ac75dfb33783c5). The thorn name will need to be changed to ML_BSSN in the parameter file and test name if this is applied to master.

[Erik Schnetter]

Please apply both.

[Ian Hinder]

Fix committed in http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=f5fda658d49efce252918ad5bfbc85c1aed8edb6, test committed in http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=ce3b0b3d87ffa53ca8acb4e1b0b5ccbbe4bcc10c.