MoL: Add declaration of Accelerator_NotifyDataModified to interface

Create issue
Issue #883 closed
Frank Löffler created an issue

Currently MoL doesn't build because the aliased function Accelerator_NotifyDataModified() is used but not declared in interface.ccl.

The attached patch declares the function which makes the linker happy. The availability of the function is already checked at runtime.


Comments (7)

  1. Erik Schnetter
    • removed comment

    Should this function really be called in MoL, or should this be done only in a development branch?

  2. Frank Löffler reporter
    • removed comment

    I am not 100% sure. However, at least one other Accelerator_* function is already declared in MoL right now. The patch would let MoL build (link) again. Whether the code calling that function should be in MoL or not would be another question.

  3. Erik Schnetter
    • removed comment

    I have a current version of MoL (r165), and this aliased function is not called. Can you check your branch?

  4. Frank Löffler reporter
    • changed status to resolved
    • removed comment

    You are right. Somehow this checkout switched to another branch, which it shouldn't have done. Committing the patch there and closing here as invalid.

  5. Ian Hinder
    • removed comment

    Sorry - this was also my fault. I forgot to add the interface.ccl declaration in my first commit, and forgot to push the second commit where I corrected this. Thanks for fixing it.

  6. Log in to comment