bashism in ThornDoc

Create issue
Issue #901 closed
Frank Löffler created an issue

ThornDoc uses '==' within 'test' to test for something being equal. However, for shell scripts this should be '='. This works in bash, since it also accepts '==', but it does not work for /bin/sh by default, which is what ThornDoc claims to be a script for. The effect is that 'make THORN-ThornDoc' prints a lot of warnings.

The attached patch fixes this by replacing '==' with '='.

Keyword:

Comments (5)

  1. Frank Löffler reporter
    • changed status to resolved
    • removed comment

    I applied the same patch to ArrangementDoc, thanks for the hint. We could resolve it by letting the scripts use bash instead, but I don't think we should unless there is some reason for using bash features.

  2. Log in to comment