Cheat code list gets locked when deleting entry

[Former user]

Original issue 382 created by 47iscool on 2014-06-18T13:06:59.000Z:

What steps will reproduce the problem?
1. Load any game, scroll through the code list
2.
3.

What is the expected output? What do you see instead?
After scrolling up and down the code list on any game it will become locked and you won't be able to scroll downward anymore

What version of the emulator are you using (official, SVN revision,...)?

SVN r814
Please provide any additional information below (Emulator settings, Console
setting,...)

[Former user]

Comment # 2 originally posted by ekeeke31 on 2014-06-18T20:59:43.000Z:

Does not happen to me,try with latest build

[Former user]

Comment # 3 originally posted by 47iscool on 2014-06-19T01:00:55.000Z:

Not trying to sound silly but, how do you guys build this stuff from source?

I get my stuff from emuCR BTW.

[Former user]

Comment # 4 originally posted by ekeeke31 on 2014-06-19T06:40:23.000Z:

https://code.google.com/p/genplus-gx/wiki/Compiling

or if it is too complicated for you, grab latest build from here:

http://code.google.com/p/genplus-gx/source/browse/trunk#trunk%2Fbuilds

[Former user]

Comment # 5 originally posted by 47iscool on 2014-06-19T07:36:31.000Z:

Thank you very much!

[Former user]

Comment # 6 originally posted by ekeeke31 on 2014-06-22T19:10:10.000Z:

[Former user]

Comment # 7 originally posted by ekeeke31 on 2014-08-15T23:28:34.000Z:

issue #394 has been merged into this issue.

[Former user]

Comment # 8 originally posted by ekeeke31 on 2014-08-15T23:28:56.000Z:

[Former user]

Comment # 9 originally posted by 47iscool on 2014-08-16T16:28:57.000Z:

Sorry to duplicate/bring this back up but the list still get locked after a while of scrolling up and down the list.

[Former user]

Comment # 10 originally posted by ekeeke31 on 2014-08-16T16:51:29.000Z:

I can not reproduce this.

If there is really an issue, you will need to be more precise like about the game / cheat file being used and the exact way you locked the list (and no, "after a while" is not precise enough).

[Former user]

Comment # 11 originally posted by 47iscool on 2014-08-16T18:08:25.000Z:

It happens with games that have a code list that you must scroll down to see the rest of the codes.

After scrolling up and down the list it will go to the bottom of the page and won't allow you to go any further. You can scroll up to the first code in the list and when you scroll back down and try to go down a page it stops at the last code on the current page.

Here, these should be able to help you;

My cheat file: https://www.firedrive.com/file/A28DDDF91C59C0C7
And, a video showing you what happens: https://www.youtube.com/watch?v=r0yASq2NXms

[Former user]

Comment # 12 originally posted by ekeeke31 on 2014-08-17T08:15:56.000Z:

I tried yourcheat file with current build and everything was fine.
Make sure you are really using the latest SVN build.

[Former user]

Comment # 13 originally posted by ekeeke31 on 2014-08-17T08:15:57.000Z:

I tried yourcheat file with current build and everything was fine.
Make sure you are really using the latest SVN build.

[Former user]

Comment # 14 originally posted by 47iscool on 2014-08-17T08:31:51.000Z:

It usually happens after loading a few games. Try loading a few games with codes lists that have more than 10 codes and scroll all the way down then back up, It may take loading three or four games with bigger code lists to reproduce.

[Former user]

Comment # 15 originally posted by ekeeke31 on 2014-08-17T10:24:58.000Z:

Still does not happen even after loading a few games.

See, that's why I was asking for exact details on how to reproduce the issue. First you said it was happening with any games, now it "usually" happen after you load a few game. I am not going to test every new scenario you come up with, this is wasted testing time.

The video you uploaded is too short and only shows the end result. I don't need to see what the bug is, I perfectly understand what a locked list means, what I need to know is what you EXACTLY did to make the bug happening and if it happens constantly when doing this.

What I need is a video where I can see you starting the emulator, loading game(s) and browsing cheat code until the bug happens. And I need you to do it several time to see if this is random or constant issue. To eventually reproduce it, I need the exact game(s) name and the associated cheat files.

[Former user]

Comment # 16 originally posted by 47iscool on 2014-08-17T15:18:44.000Z:

I got it! I know exactly how to reproduce it now!

That code list I gave you for example, use it with SK3.

Scroll all the way to the bottom, add any PAR code in the list, it can be anything.

Then delete it and go all the way to the top and when trying to go down the code list will lock and won't allow you to down past the first page anymore.

[Former user]

Comment # 17 originally posted by 47iscool on 2014-08-17T15:22:29.000Z:

One thing I forgot to mention in the above post.

Before you delete the code go down to where is says
New Code then go up one and delete the newly created code and you will see what I'm talking about.

[Former user]

Comment # 18 originally posted by 47iscool on 2014-08-17T15:29:13.000Z:

To put everything into perspective:

1. Load SK3 with the cheat file I gave you.
2. Scroll all the way to the bottom
3. Add a new GG or PAR code, for example FFF0000:0000
4. Go down to where it says "New Code"
5. Go up and delete FFF000:0000
6. Now go all the way back to the top
7. Try to go down and you won't be allowed to go past the code near the end of the page.

[Former user]

Comment # 19 originally posted by 47iscool on 2014-08-17T18:33:38.000Z:

This is the last bit of info I can give you. Hopefully you're not mad at me posting all of this. But those lasts posts WILL make the list lock on.

[Former user]

Comment # 20 originally posted by 47iscool on 2014-08-17T18:34:04.000Z:

Lock, not lock on.

[Former user]

Comment # 21 originally posted by ekeeke31 on 2014-08-17T20:36:41.000Z:

That last bits of info is fine, I managed to reproduce it.

After analyzing the code, there is indeed a bug with the scroll list after deleting an entry if there is still more than 10 entries in the list.

I probably only tested with less than 10 entries when I initially designed the cheat menu, there are some other bugs from what I can see :-/

[Former user]

Comment # 22 originally posted by 47iscool on 2014-08-17T20:55:55.000Z:

Glad you found it, and thanks for accepting it.

All in all your port of GP has the best features of any emulator port I've seen. Thanks for all you hard work on it.

[Former user]

Comment # 23 originally posted by 47iscool on 2014-08-18T01:48:43.000Z:

Just found out something else. I renamed a few codes at the bottom and it still locked.

I'm guessing it has something do do with editing codes past the 9th entry huh?

[Former user]

Comment # 24 originally posted by ekeeke31 on 2014-08-18T19:17:43.000Z:

All bugs should now be fixed in r890, please confirm you do not have anymore issues.

Up-to-date builds in
https://code.google.com/p/genplus-gx/source/browse/trunk/builds

[Former user]

Comment # 25 originally posted by 47iscool on 2014-08-18T22:18:13.000Z:

Confirmed. List doesn't get locked anymore. Thanks a lot.

I did find one bug but it isn't cheat list related. Since I see you are working on making it where you can select the BIOSes manually I tried to set one up and it froze up. It's probably a WIP right?

[Former user]

Comment # 26 originally posted by ekeeke31 on 2014-08-19T06:32:17.000Z:

Indeed, this was not supposed to be commited, i accidentaly did apparently

[Former user]

Comment # 27 originally posted by 47iscool on 2014-08-19T07:54:19.000Z:

Ahh okay. No problem though as SEGA CD still works great.

Also, thanks for implementing this for a future release. I like switching back and forth between the two different SCD USA BIOSes.