Check with TRI if they want our single particle sample
Ask TRI on the Slack channel if they have any comments / suggestions about our single particle example and if they want us to do a PR to add it as an example.
Comments (11)
-
-
reporter yes, if they are interested in us sending the particle example in a PR to their repo to have it as a basic sample. If so, check where we should put that code (I suppose in https://github.com/RobotLocomotion/drake/tree/master/drake/examples, but maybe they prefer somewhere else).
-
Yes, but should we share it upfront? Not as a PR, but as a link to our repo. Otherwise, we don't have anything to show but a video.
-
reporter Sure; do you see any issues with sharing that code?
-
Nope, just checking :).
-
reporter :+1:
-
Ok, through Slack, Drake devs have given us green light to submit a PR for the particle sample. Jeremy pointed out though that the codebase must be refactored first, to comply with their code styles and development guidelines, in order to be accepted.
-
reporter I think we should go that route and learn also their coding conventions for future PRs. I would suggest to take Jeremy's advice and look for a Drake dev volunteer to iterate privately on the branch before sending a PR.
-
reporter Btw, I think the answer to this issue is "Yes", so feel free to close this one and create a new issue to actually get our sample merged.
-
- changed status to closed
-
- changed status to resolved
- Log in to comment
@andres_fortier we're talking about code sharing, right? Besides the video, of course.