Anonymous avatar Anonymous committed 99d0868

Some status code and whitespace changes

Comments (0)

Files changed (2)

dragoman/control/main.py

         langs = LanguageList()
         doc = simplejson.loads(cherrypy.request.body.read())
         if not doc.get('abbrev') or not doc.get('name'):
-            raise cherrypy.HTTPError(403, 'Need a JSON doc with abbrev and name as keys')
+            raise cherrypy.HTTPError(400, 'Need a JSON doc with abbrev and name as keys')
         abbrev, name = doc['abbrev'], doc['name']
         langs.add(abbrev, name)
         cherrypy.response.status = 201
                 doc = simplejson.loads(cherrypy.request.body.read())
                 c = Catalog(catalog, lang)
                 c.batch(doc)
-        cherrypy.response.status = 201                
+
+        url = '/api/%s' % (catalog)             
+        cherrypy.response.status = 201
+        cherrypy.response.headers['Location'] = url
         return self.json({
             'status': 201, 'message': 'created',
-            'url': '/api/%s' % (catalog)
+            'url': url
         })
 
 

dragoman/control/web.py

 
     def POST(self, catalog, lang=None):
         if not lang or lang == '':
-            raise cherrypy.HTTPError(406)
+            raise cherrypy.HTTPError(400)
         c = Catalog(catalog, lang)
         c.initialize()
         raise cherrypy.HTTPRedirect('/catalog/%s' % catalog)
 
     def DELETE(self, catalog, lang=None):
         if not lang or lang == '':
-            raise cherrypy.HTTPError(406)
+            raise cherrypy.HTTPError(400)
         c = Catalog(catalog, lang)
         c.delete()
         raise cherrypy.HTTPRedirect('/catalog/%s' % catalog)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.