Question about getting wallpapers using HTTPS links

Create issue
Issue #32 closed
payl0ad created an issue

Hi! Thank you for your openness for your previous issue which you accepted.

In resources/application.properties you provide the urls to download wallpapers from. There are so 4 urls from which the program downloads wallpapers over HTTP. Why are you not using HTTPS for all URLs? I have tested that and it still works.

There is a small typo in the wiki title: WallpapeDownloader missing the letter r.

Perhaps in the future i'd like to create pull requests if possible but that is not allowed now.

Thanks

Comments (2)

  1. Eloy García Almadén repo owner

    Hi @AllTheseGitChoisesNGithubAint1!

    Thanks to you to contribute to this project :)

    Answering your questions:

    In resources/application.properties you provide the urls to download wallpapers from. There are so 4 urls from which the program downloads wallpapers over HTTP. Why are you not using HTTPS for all URLs? I have tested that and it still works.
    

    There is no reason for that. I started to use plain HTTP URLs because I thought they would be less problematic to treat but I realized that some sites were less problematic to parse using HTTPS. If you have tested all the providers and they work using HTTPS, then I think is a good idea to change the URLs for the next version.

    There is a small typo in the wiki title: WallpapeDownloader missing the letter r.
    

    Thank you, fixed!

    Perhaps in the future i'd like to create pull requests if possible but that is not allowed now.
    

    Thank you for the suggestion. Pull requests were not configured in Settings. It is now for devel branch. I consider master branch stable and all the changes should go to devel branch first.

    You are more than welcome to collaborate with the project, start pull requests and everything you want!!

    Thank you very much!

  2. Log in to comment