Anonymous avatar Anonymous committed 0609a2d

do the read without checking read length against buf length, that scared me

Comments (0)

Files changed (1)

 #include <err.h>
+#include <errno.h>
+#include <fcntl.h>
 #include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
 
 		if (FD_ISSET(mfd, &rd)) {
 			erase_usr();
-			do {
-				if ((rdlen = read(mfd, buf, sizeof(buf))) < 0)
-					warn("failed to read from master");
+			for (rdlen = read(mfd, buf, sizeof(buf)); rdlen > 0; rdlen = read(mfd, buf, sizeof(buf)))
 				my_write(STDOUT, buf, rdlen);
-			} while (rdlen == sizeof(buf) - 1);
+			if (rdlen < 0)
+				warn("failed to read from fd %d", mfd);
 			print_usr();
 		}
 	}
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.