NonStorage Flow-Thru Inflow does not include stored water delivery

Issue #24 resolved
Bob Lounsbury created an issue

When graphing a NonStorage node or looking at the mdb output, the Flow-Thru Inflow only includes the natural flow delivery not stored flow delivery. The flow in the link coming out of the NonStorage node is still correct, so this is a minor bug. The attached network demonstrates the issue at node BeforeDiversion.

Comments (3)

  1. Bob Lounsbury reporter

    Bug fix - closes #24. NonStorage nodes Flow-Thru Inflow did not include stored water delivery. In all of the test models this bug and the fix did not change the model solution. In essence the stored water delivery was being counted twice in two artificial links.

    → <<cset 1189f48acc50>>

  2. Bob Lounsbury reporter

    I raised an eyebrow at this while fixing issue #24, but ignored it thinking maybe someone knew more than I did. Then I tried running our upper Snake model and got a whole bunch of "No convergence in flow through:" messages.

    The code was testing if the current solver iteration flows were the same as the previous solver iteration flows, instead of checking all the current solver iteration flows. If that makes sense.

    Anyway, this change made all the "error" messages about flow through convergence go away in our upper Snake model.

    → <<cset 743855840b5e>>

  3. Log in to comment