1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#107 Merged
Repository
enzo-dev-clean
Branch
week-of-code
Repository
enzo-dev
Branch
week-of-code

TestGravity test problem: random number generator

Author
  1. Greg Bryan
Reviewers
Description

This fixes the random number generator in TestGravity to be deterministic and machine-independent. It passes the quick test suite on Columbia hotfoot cluster.

Comments (2)

  1. Britton Smith

    With this, I was able to generate local results, then rerun new simulations and have them pass continually against my local results even when I changed the test to be bitwise identical. We probably don't need to change the actual test to bitwise identical, but I am in favor of tightening the tolerance in GravityTest__test_gravity.py. How do people feel about that? Either way, the gold standard should be regenerated for this test.

  2. Greg Bryan author

    I think it would be good to tighten the tolerance. Currently it's set to 10% of the RMS force errors. I guess now that the positions are deterministic, that could be taken down to a much lower tolerance.