1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#123 Merged at 99fc56b
Repository
brittonsmith
Branch
week-of-code
Repository
enzo
Branch
week-of-code

Fixing up one zone freefall test.

Author
  1. Britton Smith
Reviewers
Description

I made some alterations to the one zone free-fall test to allow for the option of considering pressure gradient forces in determining the rate of collapse. For this, I followed the setup described in Omukai et. al. (2005). This fixes an issue I was seeing for zero-metallicity collapse where the temperature increases rapidly at high density because collapse is continuing at the freefall rate.

This is how it used to look: http://i.imgur.com/XDK9j.png

This is how it looks now: http://i.imgur.com/uJxzU.png

This new behavior can be turned off again by setting OneZoneFreefallUseEffectiveGamma to 0, which is actually the default. This may make this test a little more useful for testing high density chemistry.

Gold standard results will have to be remade.

Update: fixed header.

Comments (5)

      1. Nathan Goldbaum

        Thanks for the clarification. I don't think it's necessary to do a separate PR for enzo-3.0 since we can pull in changes from the tip of enzo-dev en masse instead of repeating pull requests over there.

        1. Britton Smith author

          Oh excellent. I anticipate there may be conflicts because I made the implementation cleaner when I ported it back to this version. If so, I will happily help resolve them.

  1. Greg Bryan

    I just ran this against the enzo 2.2 gold standard (transplanting just the changes in this pull request to enzo 2.2) and it passed all tests except for the OneZoneFreefallTest, which is to be expected since this change clearly improves on that one. Therefore I think we should pull this in now.