1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#126 Merged at 4a52471
Repository
cluster-dev
Branch
week-of-code
Repository
enzo-dev
Branch
week-of-code

Fixed typo in solve_cool.F

Author
  1. yl2501
Reviewers
Description

There appears to be a typo in solve_cool.F and has caused problems when using precision-32.

  • parameter (tolerance = 1.e-52_RKIND)
  • parameter (tolerance = 1.e-5_RKIND)

Comments (3)

  1. Matt Turk

    This looks correct to me. I'm not 100% convinced that it will require a regeneration of the gold standard, as it is a tolerance that also only applies when RadiativeCooling == 1 and MultiSpecies == 0 and precision == 32. It's definitely the right fix, though. Can you check if this requires a regeneration of the gold standard? Thanks, Yuan!

  2. Daniel Reynolds

    Thanks indeed! I just checked the code prior to my "upgrades" to the precision handling, and I did add in a typo when updating this value. I'm going to accept the PR.

  3. Greg Bryan

    The gold standard was generated for precision == 64, and this change has no effect on that, so it does not require a regeneration of the gold standard. A related issue is: does precision == 32 pass the gold-standard? I don't know the answer to that -- I plan to find out, but I don't think it should hold up the acceptance of this pull request.