1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#16 Merged at 7e58f68
Repository
clean-copy
Branch
week-of-code
Repository
enzo-dev
Branch
week-of-code

Bugfix: MetalCooling=1 missing a factor of density

Author
  1. John Wise
Reviewers
Description

This change fixes the metal cooling rate, using MetalCooling=1, which was missing a factor of density previously. Ji-hoon gets credit for this one.

Comments (4)

    1. John Wise author

      Are you talking about the message from Yuu Niino? Or the discussion about advecting the metal fields in MHD sims? Either way, this isn't related to that issue and only affects the cooling rates and not the metal densities.

      1. Matt Turk

        I meant the latter, but I think I was confused; I think I mentally inserted a multiplication by the metal field in here, in which case fraction/density would have been important. Apologies for the noise.

  1. Britton Smith

    I've tested this using the CoolingTest and it now gives the right behavior. Unfortunately, the CoolingTest was set up to test the cooling rate at n = 1 cm^-3, which is right where the cooling would be equal with this bug. I will accept this PR and update the cooling tests to better test the density dependence.