1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#197 Merged at 2edc85d
Repository
brittonsmith
Branch
week-of-code
Repository
enzo
Branch
week-of-code

Conduction helper machinery: part 2

Author
  1. Britton Smith
Reviewers
Description

This adds an option to remove the factor of dt / t_dyn in the calculation of the star particle mass. This is necessary when running with conduction as the timesteps can be very short, resulting in the minimum star particle mass criterion never being satisfied. The result: cold, star forming gas refuses to form stars and sucks heat out of the ICM, forming even more cold gas that doesn't form stars. Lather, rinse, repeat. Bad things happen.

Update 1: added mention of the star formation parameter to the conduction section as per chummels's comment.

Comments (4)

  1. chummels

    Britton Smith this looks great. The only request I have is to include a short blurb about this parameter in the "conduction" part of the docs, so that people who are running with conduction know that they should also potentially include this parameter when making a run in order to avoid problems with star formation.