Check HydroMethod compatibility for initial B field specified runs

#271 Merged at 01f5322
Repository
Deleted repository
Branch
week-of-code (2d40292dc11a)
Repository
enzo-dev
Branch
week-of-code
Author
  1. Daegene Koh
Reviewers
Description
No description

Comments (13)

  1. John Wise

    (HydroMethod != 4 || HydroMethod != 6) should be (HydroMethod != 4 && HydroMethod != 6)

  2. dcollins4096

    Why is this necessary to hard fail if this flag is set? Isn't

    CosmologySimulationInitialUniformBField
    

    completely ignored if neither MHD method is used?

    1. John Wise

      I think the point is that if you set an initial B-field, thinking that you're run an MHD simulation, this will double-check whether you are using an MHD solver.

      1. dcollins4096

        Fair enough. It's not immediately obvious that not all solvers do all things. Could you make the error message a little more informative, such as

        UniformBField requested with a non-MHD solver.  Please use one of the MHD solvers.
        

        This error message requires digging through the code to sort out the nature of the incompatibility.