1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#288 Merged at 1d36038
Repository
jwise77
Branch
week-of-code
Repository
enzo
Branch
week-of-code

Adding refinement by metal mass

Author
  1. John Wise
Reviewers
Description
  • Adding a new refinement criterion (19) to refine on metal mass instead of some minimum metallicity. This strategy favors dense metal-enriched gas and will not aggressively refine underdense enriched regions.

  • Refinement criteria is similar to baryon mass refinement, but with the minimum mass multiplied by MetallicityForRefinement * Zsolar, where Zsolar = 0.0204. Default = 1.

  • Also, fixed a bug in the hydro_rk MHD color species, where density was renormalized twice.

Comments (12)

  1. Devin Silvia

    For this comment: "...but with the minimum mass multiplied by MetallicityForRefinement * Zsolar, where Zsolar = 0.0204." Shouldn't this be updated to be more consistent/accurate -- following the discussion that was had by Britton Smith as part of updates to Grackle?

  2. Tom Abel

    One further thing to consider here would be to also reuse the MetallicityRefinementMinMetallicity parameter and use it if it is greater 0. Not necessary to accept the pull request however.