1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#295 Merged at ec36c2e
Repository
ngoldbaum
Branch
week-of-code
Repository
enzo
Branch
week-of-code

Updating star_maker_ssn to include momentum-based feedback

Author
  1. Nathan Goldbaum
Reviewers
Description

This PR includes two pieces.

  1. Where I'm updating code that's already in the repository, I'm primarily fixing floating point overflow errors and deleting trailing whitespace at the end of lines.

  2. The new code at the end of the pull request is the momentum-based feedback prescription.

It should be possible to use this feedback prescription in the AGORA test problem that's already in the repository by turning on the appropriate feedback algorithm. That said, this feedback prescription has been tested at 20 pc resolution and not the 80 pc resolution test problem. I'm happy to make suitable parameter files available if anyone wants to try running one of these simulations.

Here are some movies comparing runs with and without feedback: https://drive.google.com/folderview?id=0B7on0vW92w_bN01IWU1hU3RIeHc&usp=sharing

Comments (8)

  1. John Wise

    Except for Britton's and my small comments about the write() statement, it looks good. I'll approve after you've addressed these comment and then we can merge.