Thanks. I added a brief description of all the 16 tests in that file.
Great catch by John on the double renormalization bug. I changed this in this updated PR.
This passes the push suite!
Would it be possible to put the 2D-LongKH-AMR.enzo into its own directory? There's a general one-to-one between tests and directories, I'm going to totally forget about this one where it is.
I ran the test, and I think I did something wrong, so maybe usage could be explained. I ran 2D-LongKH.enzo on 8 cores, with changeset 9ec0bc7176a6. I do
and I get this
and for snapshot 18, I get this:
neither of which look like what I expect from the linked paper. Did I mess up? If so, could you clarify? Or are my expectations that it should look like one of the figures from the paper off?
Oh try to plot the color field and not the density. it is indeed a very subtle mixing problem that is set up here.
Ah, ok. That looks more reasonable. It doesn't look like it gets as chaotic as in the paper, is that a parameter space issue? It just kind of looks like a wind-up. Here's what I get: http://imgur.com/a/e8OQk
Its a useful starting place for people who want to do that test and looks good. I'll approve it.
Yes they did much higher resolution in the paper, but I wanted to run fast for testing and so stuck with lower resolutions default parameters. It does work in parallel however...
This looks good to me. I compiled and did a few quick runs with various parameters to make sure it ran, but didn't have the patience to see it through to useful output. I'm approving but a merge should wait until Dave confirms the run produces correct output on his machine...
I'm going through and re-testing all of the PRs. This PR, at changeset 55ce49067226, passes the push suite. It needs one more approval to merge - could somebody please do that?
Everything looks good to me. I can approve this after those two printf's that @gbryan highlighted are put in (debug) if-statements.
@jwise77 , Tom put those two statements in if(debug), I'm going to approve + merge.