Make all test problems use a power-of-two refinement factor

#340 Merged at 22b89bf
Repository
ngoldbaum
Branch
week-of-code
Repository
enzo
Branch
week-of-code
Author
  1. Nathan Goldbaum
Reviewers
Description

I'll admit, this is primarily focused on moving the test suite to yt-3, which no longer supports making projections for datasets with refinement factors that aren't a power of two.

I think testing the code using much more commonly used hydro parameters makes a lot of sense. That said, if others disagree, I can also fix the test failures this causes by making a patch for yt to disable generating projection tests for datasets with unusual refinement factors.

Comments (3)

  1. Greg Bryan

    I think this is fine. The spherical infall uses RefineBy=3 because that improves symmetry during collapse (since the collapse is centered on a cell). However, in practice, nobody uses 3.

    1. Brian O'Shea

      OK, this is a very small change and no objection has been raised on the mailing list. I'm merging the PR!