This changeset updates the species advection for MHDCT (HydroMethod=6).
Previously color fluxes were proportional to density flux, which is not correct. This fix now computes upwinded interface states for the species fields in order to use the correct value in the Riemann problem.
Additionally adds a metal advection to ProblemType 500.
ONLY works with RiemannSolver=6
ONLY works with ReconstructionMethod = 0, 6
Only pertains to HydroMethod = 6 simulations.
Other than the comments I added below, this looks good to me. I'll run the test suite and report back later.
This also looks good to me.
I fixed the comments that were made. Thanks!
All tests pass at revision 1b0ae2b (except for the new MHD metal advection tests, which unsurprisingly die because there's no prior data to compare against). I think this is ready to merge!
Can I get one more reviewer for this? @yipihey , maybe?
All of these changes look good to me. The new tests are a great addition! We should do something similar for the other hydro methods.
Agreed on the tests! Now that we've got an automated test suite, this is one of the next test-related things to consider. (Also the cosmological tests, which @chummels and I are still working on.)