#411 Merged at b493c5f
Repository
ngoldbaum
Branch
week-of-code
Repository
enzo
Branch
week-of-code
Author
  1. Nathan Goldbaum
Reviewers
Description

This includes two cleanups for ErrorExceptions.h. This fixes some issues I ran into integrating the active particles.

  • Remove compatibility code for OSX 10.4
  • ErrorExceptions.h does not need to include signal.h

I’m not sure why ErrorExceptions.h includes signal.h as it does not use any symbols from that header. Including it caused some conflicts building Enzo with active particles. I’m PRing this separately to ease review.

Comments (3)

  1. Nathan Goldbaum author

    Hmm, I enabled pipelines on my fork. Any idea why it’s not running here?

  2. MattT

    I think signal might have been from when it responded to SIG signals. If this doesnt break compilation I'm sure it's fine to remove.

  3. Brian O'Shea

    This now compiles as per Nathan’s last update to the PR, and passes the test suite vs. the current tip of enzo-dev. Looks good to me!