1. The Enzo Project
  2. Untitled project
  3. enzo-dev
  4. Pull requests

Pull requests

#62 Merged
Repository
brittonsmith
Branch
week-of-code
Repository
enzo
Branch
week-of-code

Changing MAX_ANY_SINGLE_DIRECTION from 3079 to 1024.

Author
  1. Britton Smith
Reviewers
Description

Changing MAX_ANY_SINGLE_DIRECTION from 3079 to 1024 to avoid stack overflow in solve_rate_cool.

Comments (5)

      1. Matt Turk

        Does anyone know where the +7 comes from anyway? (Ghost zones of 3 gives six.) I say keep it and assume this is for an actual max size of 1017.

        1. John Wise

          I have no idea, and searching didn't come up with anything. It actually doesn't make sense to me, especially being an odd number. Everything that I've read about vectorization says that the variables should be aligned and some multiple of 8 or 16 bytes. 1030 would be a better choice if we were to include the ghost zones. I was taking the word of someone from the "vector age" ;)