Setting the blocking factors

[Steven R. Brandt]

The setting of blocking factors in driver.cxx…

pp.addarr( "amr.blocking_factor", vector<int>{blocking_factor_x, blocking_factor_y, blocking_factor_z}); is not correct. That vector is supposed to be for levels, not components of the blocking factor. We want this: pp.add("amr.blocking_factor_x", blocking_factor_x); pp.add("amr.blocking_factor_y", blocking_factor_y); pp.add("amr.blocking_factor_z", blocking_factor_z);

‌

[Roland Haas]

Docs that describe this: https://amrex-codes.github.io/amrex/docs_html/GridCreation.html?highlight=blocking_factor

However, max_grid_size and blocking_factor can be specified as a single value applying to all coordinate directions, or as separate values for each direction.

* If max_grid_size (or blocking_factor) is specified as multiple integers then the first integer applies to level 0, the second to level 1, etc. If you don’t specify as many integers as there are levels, the final value will be used for the remaining levels.

* If different values of max_grid_size (or blocking_factor) are wanted for each coordinate direction, then max_grid_size_x, max_grid_size_y and max_grid_size_z (or blocking_factor_x, blocking_factor_y and blocking_factor_z) must be used. If you don’t specify as many integers as there are levels, the final value will be used for the remaining levels.

‌

[Roland Haas]

I made a pull request with your change (and also change max_grid_size in the same manner): https://bitbucket.org/eschnett/cactusamrex/pull-requests/12/carpetx-correct-set-x-y-z-blocking-and please review or directly apply.

[Roland Haas]

Applied as git hash 3c1378e "CarpetX: correct set x,y,z blocking and grid size" of cactusamrex