Anonymous avatar Anonymous committed 5a6d89b

Better handling of Webmachine hostspecs.

When to setup the Mochiweb socket listeners, we may get into problems
if the hostspecs consists of wildcards and "variables".

We'll try and do the best we can by filtering out sane Hostnames and
by checking that the corresponding IP addresses can be found.

Comments (0)

Files changed (1)


             Port = getenv("WEBMACHINE_PORT", "8000"),
             [[{loop, fun loop/1},
               {ip, Ip},
-              {port, list_to_integer(Port)} | Options]];
+              {port, l2i(Port)} | Options]];
         IpPorts ->
             [[{loop, fun loop/1},
-              {ip, host2ip(Ip)},
+              {ip, Ip},
               {port, Port} | Options] 
-             || {Ip, Port} <- IpPorts]
+             || {Ip, Port} <- sanitize_ipports(IpPorts)]
+%% Nb: We may get into problems here if the host spec
+%% consists of wildcards and "variables". We'll try and
+%% do the best we can by filtering out sane Hosts and
+%% check that the corresponding IP address can be found.
+sanitize_ipports(IpPorts) -> 
+    sanitize_ipports(IpPorts, ordsets:new()).
+sanitize_ipports([{HostSpec,Port}|Tail], Dict) ->
+    Host = string:join([E || E <- HostSpec,is_list(E),E /= "*"], "."),
+    case host2ip(Host) of
+        {ok, Ip} ->
+            sanitize_ipports(Tail, ordsets:add_element({Ip,l2i(Port)},Dict));
+        {error, X} ->
+            error_logger:info_msg(
+              "~p(~p): failed to lookup Host=~p, ignoring this hostspec...~n",
+              [?MODULE,?LINE,X]),
+            sanitize_ipports(Tail, Dict)
+    end;
+sanitize_ipports([], Dict) ->
+    ordsets:to_list(Dict).
+l2i(L) when is_list(L)    -> list_to_integer(L);
+l2i(I) when is_integer(I) -> I.
 getenv(Var, Default) ->
     case os:getenv(Var) of false -> Default; Any -> Any end.
 %% Try to return an IP address since that is what mochiweb wants.
 host2ip(X) ->
     case inet_parse:address(X) of
-        {ok, _IpTuple} -> X;
+        {ok, _IpTuple} -> {ok,X};
         _ ->
             case inet:gethostbyname(X) of
-                {ok,#hostent{h_addr_list=[Ip|_]}} -> Ip;
-                _                                 -> X
+                {ok,#hostent{h_addr_list=[Ip|_]}} -> {ok,Ip};
+                _                                 -> {error,X}
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.