still php 7.2 count() problem in version 0.9.8.0

Issue #12 resolved
Eelco Schreurs created an issue

count(): Parameter must be an array or an object that implements Countable

Whoops\Exception\ErrorException …/public/packages/bitter_shop_system/src/Bitter/ShopSystem/ProductHelper.php:187

Still problem on line 187 php 7.2

/packages/bitter_shop_system/src/Bitter/ShopSystem/ProductHelper.php
    {
        $slug = $this->productEntry->getAttribute("product_slug");

        if (strlen($slug) === 0) {
            return URL::to("/shop/details", 'view_express_entity', $this->productEntry->getId())->__toString();
        } else {
            return URL::to("/shop/details", $slug)->__toString();
        }
    }

    /**
     * @return float
     */
    public function getAverageRating()
    {
        $reviews = $this->productEntry->getProductReviews();

        $avgRating = 0;

        if (count($reviews) > 0) {
            $totalRating = 0;

Comments (4)

  1. Eelco Schreurs reporter

    should be if(isset($reviews) && count($reviews) > 0) { .... etc..

    and on line 254:

    …/public/packages/bitter_shop_system/src/Bitter/ShopSystem/ProductHelper.php:254
    
  2. Eelco Schreurs reporter

    and line 210 in productHelper.php

    and /packages/bitter_shop_system/blocks/express_entry_detail/templates/bss_product_detail/view.php

    and line 453 of: /packages/bitter_shop_system/blocks/express_entry_detail/templates/bss_product_detail/view.php:453

    if($entry->getProductReviews() !== null && ... )

  3. Log in to comment