Re-Defines in DagMC
Issue #11
resolved
There seems to be an overlapping define in the DagMC.cpp file.
#define CATEGORY_TAG_LENGTH 32
Shouldn't this be referenced from MBTagConventions?
Small thing, but I thought I would bring it up. Happy to correct and PR this if needed.
Comments (6)
-
-
yes, I agree It is called CATEGORY_TAG_SIZE in there, and it is used in cubit reader, among other things
-
reporter
Sounds good. I have a fix locally ready to push, but before I do I just want to ping @gonuke and @makeclean to make sure there isn't another reason for doing this.
-
reporter
Spoke with Andy about this today. Seems as though that define is there in order to accommodate a future change to Category Tags that can be of a different size.
-
reporter
Had a further chat with Paul and Andy about this today. These calls in dagmc should definitely be using the MBTagConventions. I'll submit a PR to correct this shortly.
-
- changed status to resolved
Merged PR from Patrick to avoid the re-definition in DagMC
- Log in to comment
Patrick, not sure why that is the case but yes, it should be in MBTagConventions. There is CATEGORY_TAG_SIZE that could be reused in DagMC if that would render CATEGORY_TAG_LENGTH redundant.