Autoreconf failure

[Patrick Shriwise]

I’m seeing an error when running autoreconf locally:

configure.ac:1601: error: required file 'config/MOABConfig.h.in' not found

I think this has something to do with this line referring to config/MOABConfig.cmake.in rather than config/MOABConfig.cmake.h.in

https://bitbucket.org/fathomteam/moab/src/e6a23a793c5f140f12928c64c5ab57fac5b85bb6/configure.ac#lines-6

It seems others are running into this problem as well (https://github.com/svalinn/DAGMC/discussions/828#discussioncomment-3456282).

Any suggestions?

[Vijay M]

This was a bug in an old release where the header was removed from the tarball. That was fixed immediately in a patch release as well I think.

Your suggestion for the fix is wrong. The line config/MOABConfig.cmake.in says that configuration will output a file with some appropriate options in config/MOABConfig.cmake that is typically consumed by CMake based codes using a FindMOAB.cmake. The idea was to make a downstream CMake app use MOAB easily even if MOAB was installed with autotools.

[Patrick Shriwise]

Your suggestion for the fix is wrong.

Ah, yeah I see that now. Thanks. I had updated my MOAB version before trying that change and got a false positive there.

Would you mind pointing me to the PR with the fix? I’m curious as to which versions will have this issue.

‌

[Vijay M]

After some search on merged PRs, I couldn’t find one that was an obvious fix to this. The issue I think was that at some point the MOABConfig.h got committed to repo (and it shouldn’t be since it is automatically generated), and it caused configuration problems.

I’d be happy if you’d recommend users to upgrade to v5.4.0. Or if you tell me exactly which version/tarball had this problem, I can suggest the right fix.

[Patrick Shriwise]

After some search on merged PRs, I couldn’t find one that was an obvious fix to this. The issue I think was that at some point the MOABConfig.h got committed to repo (and it shouldn’t be since it is automatically generated), and it caused configuration problems.

I see. Thanks for digging into it further!

I did recommend that the user update to a newer version and this fixed their issue They were using Version 5.1.0 before, in case you wanted to take a look.

[Patrick Shriwise]

Marking as resolved since this has been fixed.

[Vijay M]

Yikes. 5.1.0 was like 3-4 years back :) Definitely ask them to upgrade please.