Eigen ext cmake config
Patrick Shriwise
Branch: pshriwise/moab:eigen_ext_cmake_config
Branch: fathomteam/moab:vijaysm/eigen-external-dep
Declined
Declined pull request
@pshriwise I am declining this PR due to numerous conflicts as a result of rebase on vijaysm/eigen-ext-dep branch. However, I cherry-picked your commits from this branch and created a new one (pshriwise/eigen_ext_cmake_config) with additional changes. Now I think everyone should be happy. Please review the other one.
Closed by: Vijay M·2017-03-30
This should fix problems with cmake configurations provided by cmake and autotools builds.
It seems that two input cmake configuration files are required, one for cmake and one for autotools. I've re-added the old one that autotools used to use in the master branch. It now uses that as before. That was the main issue I was running into.
I've renamed (perhaps poorly) the cmake configuration file (now MOABConfig.cmake.cmake) and added some explicit library variables to it. The
DAGMC_LIBRARIESvariable should probably only be set if DAGMC is build, but I've included it for now to make sure that DAGMC can automatically configure with a cmake build and install of MOAB.The results of each configuration file in the install location are still quite different and I'm wondering if there is a better way to get them to converge on something more consistent.
Creating a separate file for the MOABConfig.cmake when building with autotools.
Adding explicit library paths to cmake configuation.
Renaming cmake MOABConfig file.
Removing commented lines from config file.