Obb SAH
Patrick Shriwise
Branch: pshriwise/moab:obb_SAH
Branch: fathomteam/moab:master
Declined
Declined pull request
Declining the PR since the changeset has become stale and conflicted. If necessary, can rebase and re-submit a merge request again some point later.
Closed by: Vijay M·2021-01-27
This PR is the first in a series of PRs intended to increase the quality of OBBTrees generated in MOAB.
This contains several changes to the
OrientedBoxTreeTool
andOrientedBox
classes including:a refactor of the
build
method into generic tree generation methods likelink_node
,split_node
,create_node
, andcreate_leaf_node
extention of the
OrientedBoxTreeTool::Settings
structure to allow for multiple split cost heuristicsthe addition of a simplified Surface Area Heuristic (SAH) for evaluating box split costs (more details in the documentation of the new method)
It is worth nothing that the default behavior (heuristic and settings) of the OBBTree is the same after these changes, but that it now allows for different options to be accessed if desired by an exterior application (in our case, DAGMC)
For reviewers I'd like to make a couple things clear. I'm:
a) open to any critique as to the implementation and/or design of these new features in the tool
b) not in a large hurry to have this merged and am hoping for some discussion surrounding the changes
basically, this is going to contribute to my thesis work so I'd these PRs to be a lasting, valuable contribution to MOAB and as such I want to get it right :)