FIAT needs a unit test framework
Issue #13
resolved
FIAT has virtually no tests. Expand testing to reach decent level of coverage.
Comments (7)
-
-
- changed status to resolved
FIAT now has a unit test framework, thanks to Aslak, Nico, David, Miklós, Garth, etc.
Second task is now to write unit tests. Let's not accept new features without tests.
-
reporter
@blechta I think we could do with a new 'contributing' guide to help contributors with the process, e.g. adding tests. Something could be added to https://bitbucket.org/fenics-project/docs.
-
I'm not sure that it needs a guide. Do you think that anybody, who is able to understand a relevant piece of code and contribute there, will not be able to go through the test dir and add something relevant there when asked to do that by an integrator? I think that most important is discipline of developers/integrators not to merge anything without appropriate coverage.
-
Yes, but it's easier for everyone if the requirement to add tests is spelt out for new contributors. And also it reminds new developers/integrators that they should pay attention to features arriving without tests.
-
Yes, that's already stated here https://fenicsproject.org/contributing/#testing. If we would like to move that to RTFD page I'd suggest to file a more general issue stating what should be done in these regards.
-
reporter
I think it could be stated much more clearly and with more detail on the work flow, making pull requests, test framework, etc.
- Log in to comment
I've already started unit testing framowork (continuing the work of Aslak and Nico). It's in master. After a long time we are also running regression test, see
#3. So this has been improved recently.I wasn't tough enough in email discussion with Firedrake people to require them to write tests for their additions. I'll try to cover FFC elements being moved to FIAT in future.