PointIntegralSolver does not correctly call apply() on vectors

[Prof Garth Wells]

PointIntegralSolver does not call apply() on vectors object after setting values. This can cause a PETSc triggered crash.

Once case was easy to fix, and one is not. The latter case is not straightforward because the read/set calls are inside a tight loop. Calling apply inside the loop is dead slow.

Tests have been disabled and half-fix is in ba9b50e0c2b21caa9368e4a1a4db69c74b95d590

[Johan Hake]

Would it be possible to call:

_scheme->solution()->vector()->apply("insert");

outside the vertex loop?

Or is it a problem that we also call get_local inside the loop and, apply needs to be called in between a get and set call?

[Prof Garth Wells]

apply should be called between set/add' andget`.

[Johan Hake]

Ok, I will fix this.

[Prof Garth Wells]

Has this been fixed?

[Johan Hake]

No. But it should be fixed in my multistage branch, which I intend to merge next week.

[Prof Garth Wells]

Has the fix been merged?

[Johan Hake]

No, I will have a new look at it next week.

[Johan Hake]

Should be fixed by merging the multistage branch: b3e66cb

[Prof Garth Wells]

Removing milestone: 1.4 (automated comment)