PointIntegralSolver does not correctly call apply() on vectors
Issue #215
resolved
PointIntegralSolver does not call apply() on vectors object after setting values. This can cause a PETSc triggered crash.
Once case was easy to fix, and one is not. The latter case is not straightforward because the read/set calls are inside a tight loop. Calling apply inside the loop is dead slow.
Tests have been disabled and half-fix is in ba9b50e0c2b21caa9368e4a1a4db69c74b95d590
Comments (9)
-
-
reporter apply
should be called betweenset/add' and
get`. -
Ok, I will fix this.
-
reporter Has this been fixed?
-
No. But it should be fixed in my multistage branch, which I intend to merge next week.
-
reporter Has the fix been merged?
-
No, I will have a new look at it next week.
-
- changed status to resolved
Should be fixed by merging the multistage branch: b3e66cb
-
reporter - removed milestone
Removing milestone: 1.4 (automated comment)
- Log in to comment
Would it be possible to call:
outside the vertex loop?
Or is it a problem that we also call
get_local
inside the loop and, apply needs to be called in between aget
andset
call?