Remove TAO as stand-alone optional dependency and use via PETSc

[Prof Garth Wells]

See discussion at http://fenicsproject.org/pipermail/fenics/2014-March/001335.html.

[Jan Blechta]

@cmaurini Now DOLFIN can't be build on PETSc release 3.4.4 because in CMakeLists.txt there is assumption that there is petsctao.h in PETSc 3.4.4. It can't overriden by -DDOLFIN_ENABLE_TAO:BOOL=OFF or -DPETSC_ENABLE_TAO:BOOL=OFF, -DENABLE_PETSC_TAO:BOOL=OFF.

[Corrado Maurini]

@blechta I was just checking this. This pull-request should fix the issue:

https://bitbucket.org/fenics-project/dolfin/pull-request/129/fix-issue-267/diff

[Prof Garth Wells]

@blechta Can you test Corrado's change? If it works for you I'll merge it.

[Jan Blechta]

@garth-wells It works but proposed changeset contains messy merges...

[Corrado Maurini]

Sorry, do you want me to submit a new pull request or may you implement the change directly?

[Jan Blechta]

@cmaurini Non fast-forward merging without a purpose is not good, see PETSc git workflow which applies to DOLFIN also. It would be logical to continue fixing it where you finished but without merging next.

[Corrado Maurini]

@blechta After 20 minutes trying to understand git, I gave up and submitted a clean pull-request )-:

https://bitbucket.org/fenics-project/dolfin/pull-request/130/fix-issue-267-petsc-version-test-for/diff

I hope this is fine now.

[Prof Garth Wells]

Could we have another go at sorting this one out? It would be good to get it into the 1.4 release.

[Corrado Maurini]

@garth-wells I think this is fine now. What do you want exactly? Now with

 # Enable TAO from PETSc for PETSc verion > 3.4
  if ((PETSC_VERSION VERSION_GREATER 3.4.100) OR (DOLFIN_ENABLE_TAO))
    set(PETSC_ENABLE_TAO TRUE)
  endif()

in CMakeList.txt if you compile with petsc-dev you need to set a cmake option -DDOLFIN_ENABLE_TAO = true. If you compile with the upcoming petsc-3.5 (probably 01/06 according to petsc mailing list), it will automatically compile with the TAO solver.

[Prof Garth Wells]

Removing milestone: 1.4 (automated comment)