Cannot abort make runtests
Issue #316
resolved
I tried to Ctrl+C a "make runtests" process and it just kept on and on... Rather annoying.
Comments (15)
-
-
Not for me with the latest master. Where in the process do you press ctrl-c?
-
reporter
Most of the time a test will be running. Pressing Ctrl+C aborts the currently running test and gets me back to the commandline. But a process in the background keeps spawning the rest of the tests. Holding down Ctrl+C won't work, the rest of the tests will keep spawning.
-
The error is reproducable by running the unit tests from the
test/unitdirectory. -
ok, then just press
Ctrl+Zfollowed bykill %. -
reporter
Ok, that still works.
-
@logg That's many more key strokes than
Ctrl+c. What it is that has changed in the test scripts? -
There seem to have been two recent changes (in test/unit/test.py):
- Changing from getstatusoutput to get_status_output
- Changing the command to be run from
cd dir && python test.pytoos.chdir + python test.py
-
- marked as critical
-
I'be marked this a critical because my machine is going crazy with tests that I can't kill.
-
The reason is that we switched to use
os.systemas default method forinstant.get_status_output. We can either set the environment:export INSTANT_SYSTEM_CALL_METHOD=SUBPROCESSwhen running the tests in
CMake, or maybe easier hardcode it in the script just before we importget_status_output.os.environ["INSTANT_SYSTEM_CALL_METHOD"] = "SUBPROCESS" -
I don't care what the long term fix is, but I'd like to revert right away the change that screwed this up. I shouldn't have to reboot my computer to kill the tests.
-
I've switched the default back to
subprocess, except on Windows where it remainsos.system.https://bitbucket.org/fenics-project/instant/commits/d36816f30d48ca7bedb2f34478c507ff4b3db821
-
- changed status to resolved
-
- removed milestone
Removing milestone: 1.5 (automated comment)
- Log in to comment
I noticed this too. Where's the change?