wrong results in VectorSpaceBasis is_orthogonal

Hi, consider

from dolfin import *
import numpy as np

mesh = UnitSquareMesh(4, 4)
V = VectorFunctionSpace(mesh, 'CG', 1)

# Basis which is not orthogonal
e0 = interpolate(Constant((1, 2)), V)
normalize(e0.vector(), 'l2')

e1 = interpolate(Constant((2, 1)), V)
normalize(e1.vector(), 'l2')

basis_f = [e0, e1]
basis_v = [e.vector() for e in basis_f]

D = np.zeros((2, 2))
for i, ei in enumerate(basis_v):
    for j, ej in enumerate(basis_v):
        D[i, j] = ei.inner(ej)
print D
basis = VectorSpaceBasis(basis_v)
print 'Is orthogonal', basis.is_orthogonal()

This is due VectorSpaceBasis::is_orthogonal using abs instead of std::abs. Greping through source abs is also used in VectorSpaceBasis::is_orthonormal and demo of auto-adaptive Navier-Stoke solver

Comments (1)